fix wrong tracing location of fetch data #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zhenghh04 and @hariharan-devarajan,
If we use
dlp.iter
insidemain.py
, this does not reflect the real fetch data since the data is already fetched insideDataLoader.next()
. Because of this, we ended up tracing the fetching of batch data that resides in the memory instead of tracing its fetching duration from filesystem or other sources.This PR addresses the problem where we put
dlp.iter
inside the dataloader, as close as possible to the dataset itself.For dali dataloader, I haven't implemented the fix since there is no visible iteration there (DALI uses
share_outputs
)Note: @hariharan-devarajan when we bump the dftracer version, we should provide the name of the
dlp.iter
.I left a note to change
dlp.iter
todlp.iter(..., name=self.next.__qualname__)