-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental reconcile/rest API metric sanity test to E2E Tests #84
Add experimental reconcile/rest API metric sanity test to E2E Tests #84
Conversation
16cd12a
to
de91d75
Compare
Signed-off-by: Jonathan West <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
de91d75
to
f399ca6
Compare
Signed-off-by: Jonathan West <[email protected]>
# - If the number is higher, this implies we are updating the .status or .spec fields of resources more than is necessary. | ||
PUT_REQUEST_PERCENT=`expr "$DELTA_PUT_REQUESTS"00 / $DELTA_POST_REQUESTS` | ||
|
||
if [[ "`expr $PUT_REQUEST_PERCENT \> 40`" == "1" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these thresholds calculated? Do we compare the metrics before and after and use them as the baseline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just arbitrary thresholds (guesses) about what a 'normal' set of metrics should be:
- If we find that they are too restrictive, we should increase them.
- If we find that they are too lax, we should decrease them.
But these numbers aren't scientific by any means, they are just a guess that can serve as a starting point to allow us to refine them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jgwest
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
N/A