Skip to content

Commit

Permalink
chore: fix run target (#57)
Browse files Browse the repository at this point in the history
Signed-off-by: Leonardo Luz Almeida <[email protected]>
  • Loading branch information
leoluz authored Nov 11, 2024
1 parent 46b71b3 commit ca66160
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ lint-fix: golangci-lint ## Run golangci-lint linter and perform fixes.
##@ Run

.PHONY: run
run: build goreman ## Run all ephemeral-access components defined in the Procfile.
run: build-go goreman ## Run all ephemeral-access components defined in the Procfile.
$(GOREMAN) start

.PHONY: run-controller
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ spec:
- group1
if: "true"
ordinal: 1
friendlyName: "Devops (AB)"
friendlyName: "Devops (Write)"
1 change: 1 addition & 0 deletions internal/backend/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ func (s *DefaultService) GetGrantingAccessBinding(ctx context.Context, roleName
continue
}

s.logger.Debug("matching subjects with user groups", "subjects", subjects, "groups", groups)
if s.matchSubject(subjects, groups) {
grantingBinding = &bindings[i]
break
Expand Down
1 change: 1 addition & 0 deletions internal/backend/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ func serviceSetup(t *testing.T) *serviceFixture {
persister := mocks.NewMockPersister(t)
logger := mocks.NewMockLogger(t)
logger.EXPECT().Debug(mock.Anything, mock.Anything).Maybe()
logger.EXPECT().Debug(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Maybe()
logger.EXPECT().Info(mock.Anything, mock.Anything).Maybe()
svc := backend.NewDefaultService(persister, logger, ControllerNamespace, AccessRequestDuration)
return &serviceFixture{
Expand Down

0 comments on commit ca66160

Please sign in to comment.