Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement the AccessRequest reconciliation mvp #5

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Jul 16, 2024

This PR aims to implement all state transitions in the AccessRequest status field.

@leoluz leoluz marked this pull request as ready for review July 24, 2024 15:12
Copy link

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Probably time to start thinking about how to test the big reconcile function, or at least the smaller functions.

Most of my comments are stylistic, feel free to ignore if the style sounds bad. :-)

api/v1alpha1/accessrequest_types.go Outdated Show resolved Hide resolved
api/v1alpha1/accessrequest_types.go Outdated Show resolved Hide resolved
api/v1alpha1/accessrequest_types.go Show resolved Hide resolved
internal/controller/accessrequest_controller.go Outdated Show resolved Hide resolved
internal/controller/accessrequest_controller.go Outdated Show resolved Hide resolved
leoluz added 2 commits July 24, 2024 14:29
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
@leoluz leoluz merged commit 06173b8 into argoproj-labs:main Jul 24, 2024
2 checks passed
@leoluz leoluz deleted the controller-mvp branch July 24, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants