Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend-role): adding list verbs on applications and appprojects for backend-role #61

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

dlactin
Copy link
Contributor

@dlactin dlactin commented Nov 18, 2024

Added list permissions for the backend role. Currently testing this out in a sandbox environment and ran into permission issues.

E1118 23:16:59.075594       1 reflector.go:150] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:232: Failed to watch argoproj.io/v1alpha1, Kind=AppProject: failed to list argoproj.io/v1alpha1, Kind=AppProject: appprojects.argoproj.io is forbidden: User "system:serviceaccount:argocd-sandbox:backend" cannot list resource "appprojects" in API group "argoproj.io" at the cluster scope
2024-11-18T23:10:51.041Z	ERROR	backend error	{"error": "error getting application"}
W1118 23:11:26.306366       1 reflector.go:547] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:232: failed to list argoproj.io/v1alpha1, Kind=Application: applications.argoproj.io is forbidden: User "system:serviceaccount:argocd-sandbox:backend" cannot list resource "applications" in API group "argoproj.io" at the cluster scope

@dlactin dlactin requested a review from a team as a code owner November 18, 2024 23:33
@dlactin dlactin force-pushed the update-backend-role-verbs branch from f925e1b to 4e8db61 Compare November 18, 2024 23:34
@leoluz
Copy link
Collaborator

leoluz commented Nov 19, 2024

@dlactin Tks for your contribution!

This is a bit strange because the backend doesn't need list to get the Argo CD Application. Have you applied this change you your sandbox and confirm it fixed the issue? If not, please provide the backend-rolebinding live state as I am suspecting about something else as well.

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tks for contributing!

@leoluz leoluz merged commit 7c37f0b into argoproj-labs:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants