feat: add helm release helm param to fix multi helm sources updates #1040
+72
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-napoleone
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
|
@etienne-napoleone thanks for the contribution. Can you address the CI failures while we're reviewing it? |
|
Sorry, I might later when I have more bandwidth but that will be in a while. If someone has the time to check if the approach seems good and make a better PR with it, it would be nice! It's working as expected using a personal image, for both multi helm sources (with the helm-release param) and single helm source (without the param). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an implementation idea to fix the bug where multiple helm sources applications doesn't update the correct pod with the correct image.
The approach is to introduce a
argocd-image-updater.argoproj.io/%s.helm.release-namelabel to specify which helm release is targeted by an alias.I'm not sure it's the correct approach, but tested on my side and it seems to be working as expected.
related to #821