fix: filter images by image-list annotation #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziouf
force-pushed
the
master
branch
8 times, most recently
from
45549e3
to
02a5542
Compare
Signed-off-by: Cyril MARIN <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 66.27% 66.35% +0.07%
==========================================
Files 22 22
Lines 2150 2155 +5
==========================================
+ Hits 1425 1430 +5
Misses 591 591
Partials 134 134 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
requested changes
May 27, 2024
| } | ||
| return false | ||
| } | ||
|
|
||
| // GetImagesFromApplication returns the list of known images for the given application | ||
| func GetImagesFromApplication(app *v1alpha1.Application) image.ContainerImageList { |
There was a problem hiding this comment.
I am not really like such approach, because you change total sense of this function. I think it would be better to add validation here. Either you need rename function and change comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #650
@jannfis