Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary name - Dockerfile and manager manifest vs. release.Dockerfile #10

Closed
wants to merge 1 commit into from

Conversation

filiprafaj
Copy link
Contributor

the manager manifest uses command /manager
this is not present in the released image - the binary is called rbac-operator

I'm really not sure if this is the right way to fix it, but the issue is there

@filiprafaj filiprafaj changed the title unify binary name in Dockerfile and manager manifest with the release… binary name - Dockerfile and manager manifest vs. release.Dockerfile Nov 14, 2024
@ggkhrmv
Copy link
Collaborator

ggkhrmv commented Nov 14, 2024

Hi @filiprafaj , what issue does this PR fix? I don't really get your point, thank you! :)

@filiprafaj
Copy link
Contributor Author

I use make build-installer to generate manifests
the resulting deployment have:

containers:
- name: manager
  image: quay.io/argoprojlabs/argocd-rbac-operator:v0.1.2
  command:
   - /manager
  ...

but the /manager is not present in the quay.io/argoprojlabs/argocd-rbac-operator:v0.1.2 (the binary is called /rbac-operator)

@ggkhrmv
Copy link
Collaborator

ggkhrmv commented Dec 9, 2024

I use make build-installer to generate manifests the resulting deployment have:

containers:
- name: manager
  image: quay.io/argoprojlabs/argocd-rbac-operator:v0.1.2
  command:
   - /manager
  ...

but the /manager is not present in the quay.io/argoprojlabs/argocd-rbac-operator:v0.1.2 (the binary is called /rbac-operator)

@filiprafaj okay i get it now :) I have made adjustments, I'll mention you in the commit and release, thank you for your contribution <3

@ggkhrmv ggkhrmv closed this Dec 9, 2024
@filiprafaj filiprafaj deleted the unify-binary-name branch December 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants