fix: Fixes git over azure devops Fixes #11705

[clkamp]

Fixes #11705

Verification

Tested it in a local dev environment, the fix is the one suggested in #11705 (comment)

[eduardodbr]

Hey @clkamp ,

the CI is failing due to some flaky tests that were already fixed and merged to master, can you please merge them?

[clkamp]

@agilgur5 Could you review and possibly merge this?

[agilgur5]

Sorry I've been passing a kidney stone the past month per my status (think I'm finally in the clear now, although the doctors aren't 100% sure...) among other things.

I left a comment in-line with some suggestions. Ideally we should limit this to Azure DevOps repos and only set it per request as well.

Could you also add a unit test for this?

[clkamp]

Thanks for your review and sorry for my late reply.
For the moment I just included your suggestion, you are right its much more future proof. I'm not sure how to test for azure devops Repos and all other places that applied a fix for this also did not check for it.
Would you be fine with accepting it in this state or should I further investigate how to limit the fix to azure repos?

[agilgur5]

Would you be fine with accepting it in this state [...]?

No, as I wrote before, this can cause issues and unexpected behavior for other providers.
If it's running on all repos, it should at the very least be behind an environment variable and not the default behavior.

I'm not sure how to test for azure devops Repos

You can check the URL in a.Repo for an Azure DevOps URL, no?

You also missed these two other parts from my previous review comment:

[...] and only set it per request as well.

Could you also add a unit test for this?

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs.

[github-actions]

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.