Update eval_tracking.py #267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broke eval_tracks into smaller functions
johnwlambert
reviewed
Oct 5, 2021
| @@ -104,176 +104,149 @@ def get_distance(x1: Dict[str, np.ndarray], x2: Dict[str, np.ndarray], name: str | |||
| raise NotImplementedError("Not implemented..") | |||
|
|
|||
|
|
|||
| def eval_tracks( | |||
| def get_frame_data( | |||
There was a problem hiding this comment.
hey @ahuller3, how long does get_frame_data() take compared to the mot metrics eval function call?
| acc_c, | ||
| acc_i, | ||
| acc_o, | ||
| ): |
There was a problem hiding this comment.
No return type? Also no types on acc_c, acc_i, acc_o ...
Also, this function has way too many arguments. It seems like we probably needs a refactor.
|
|
||
| for ind_frame in range(len(path_track_data)): | ||
| if ind_frame % 50 == 0: | ||
| logger.info("%d/%d" % (ind_frame, len(path_track_data))) |
There was a problem hiding this comment.
Probably:
logger.info("%d/%d", ind_frame, len(path_track_data))| if ind_frame % 50 == 0: | ||
| logger.info("%d/%d" % (ind_frame, len(path_track_data))) | ||
| if not os.path.exists(path_gt): | ||
| logger.warning("Missing ", path_gt) |
There was a problem hiding this comment.
Missing a placeholder in this log format string.
| def write_summary_to_file( | ||
| acc_c, | ||
| acc_o, | ||
| ID_gt_all: List[str], |
There was a problem hiding this comment.
Does this actually have to be List or can it be Collection or Iterable or Sequence?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broke eval_tracks into smaller functions. Still needs comments and some type annotations.