Add map root path when visualizing data #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +15,7 @@ | |||
|
|
|||
| _ZORDER = {"AGENT": 15, "AV": 10, "OTHERS": 5} | |||
|
|
|||
| _PathLike = Union[str, "os.PathLike[str]", None] | |||
There was a problem hiding this comment.
I think this would be more natural as:
_PathLike = Union[str, "os.PathLike[str]"]Then it is up to a user to use an Optional[_PathLike] if the None is permissable.
There was a problem hiding this comment.
@mgilson-argo Thank you for your review, and I modified the PathLike expression based on your advice.
| @@ -41,7 +44,10 @@ def viz_sequence( | |||
|
|
|||
| if lane_centerlines is None: | |||
| # Get API for Argo Dataset map | |||
| avm = ArgoverseMap() | |||
| if map_root is not None: | |||
| avm = ArgoverseMap(map_root) | |||
There was a problem hiding this comment.
What's the default in ArgoverseMap if map_root isn't passed? I would have expected it to just be None anyway. If that's the case, you could just do:
avm = ArgoverseMap(map_root)Either way...
There was a problem hiding this comment.
If you do not pass the map_root to ArogverseMap, it would be ROOT=Path(__file__).resolve().parent.parent.parent / "map_files".
Related Links:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello argoverse-api developers. I add a new argument to the function viz_sequence so that we can indicate the map root path when visualizing map and trajectory data. My change might not follow coding rules of your team. If so, I am happy to change my code to follow your guidelines. Thanks.