changes based off feedback

arigl · Nov 1, 2023 · 5008892 · 5008892
1 parent 7821c2d
commit 5008892
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/index.css b/index.css
@@ -1,13 +1,22 @@
+html {
+  box-sizing: border-box;
+}
+*, *:before, *:after {
+  box-sizing: inherit;
+}
+
 body {
   background-color: hsl(212, 45%, 89%);
-  display: flex;
-  align-items: center;
-  flex-direction: column;
+    display: flex;
+    min-height: 100vh;
+    align-items: center;
+    flex-direction: column;
+    justify-content: center;
 }
 
-.main {
+main {
   background-color: white;
-  width: 250px;
+  width: 270px;
   border-radius: 15px;
   display: flex;
   justify-content: center;

diff --git a/index.html b/index.html
@@ -22,21 +22,21 @@
     <title>Frontend Mentor | QR code component</title>
   </head>
   <body>
-    <div class="main">
-      <img class="qr" src="image-qr-code.png" />
+    <main>
+      <img class="qr" src="image-qr-code.png" alt="QR Code for frontendmentor.io" />
       <div class="text">
         <h1>Improve your front-end skills by building projects</h1>
         <h2>
           Scan the QR code to visit Frontend Mentor and take your coding skills
           to the next level
         </h2>
       </div>
-    </div>
+    </main>
     <div class="attribution">
       Challenge by
       <a href="https://www.frontendmentor.io?ref=challenge" target="_blank"
         >Frontend Mentor</a
-      >. Coded by <a href="#">Your Name Here</a>.
+      >. Coded by <a href="#">Alex Rigl</a>.
     </div>
   </body>
 </html>