Feat(eos_designs): Improve ptp settings for p2p_links

[laxmikantchintakindi]

Change Summary

Improve ptp settings for p2p_links

Related Issue(s)

Fixes #2698

Component(s) name

arista.avd.eos_designs

Proposed changes

PTP knobs are available in connected_endpoints:

    ptp:
      enable: < true | false | default -> false | Required >
      # These are the default settings:
      # - The global PTP profile parameters will be applied to all connected endpoints where ptp is manually enabled.
      # - `ptp role master` is set to ensure control over the PTP topology.
      endpoint_role: < follower | bmca | default -> follower >
      profile: < aes67 | smpte2059-2 | aes67-r16-2016 | default -> aes67-r16-2016 >

These would be valuable to have also in l3_edge p2p_links for L3 devices.

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4612
# Activate the virtual environment
source test-avd-pr-4612/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/ptp-p2p-links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/ptp-p2p-links --force
# Optional: Install AVD examples
cd test-avd-pr-4612
ansible-playbook arista.avd.install_examples

[carlbuchmann]

Please add test coverage in eos_designs_unit_tests scenario

[laxmikantchintakindi]

Please add test coverage in eos_designs_unit_tests scenario

Added.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

Instead of this I think the PTP should be moved to some other get_xxxx function, only called when it is not a port-channel. Please take a step back and analyze the chain of functions called and see where it fits. Thanks.

[laxmikantchintakindi]

Fixed.

[MaheshGSLAB]

LGTM