Feat(eos_cli_config_gen): Add support for MPLS RSVP #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4634
# Activate the virtual environment
source test-avd-pr-4634/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@rsvp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,rsvp --force
# Optional: Install AVD examples
cd test-avd-pr-4634
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/mpls.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
rsvp
branch
2 times, most recently
from
f2f78ad
to
30f3528
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Oct 25, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_cli_config_gen/documentation/devices/port-channel-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/mpls.cfg
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
rsvp
branch
2 times, most recently
from
f8cd654
to
823ed44
Compare
MaheshGSLAB
reviewed
Nov 5, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
rsvp
branch
6 times, most recently
from
6964549
to
eb9f8df
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls.j2
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
reviewed
Nov 14, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Outdated
Show resolved
Hide resolved
| - str | ||
| min: 1 | ||
| max: 320 | ||
| p2mp_enabled: |
There was a problem hiding this comment.
!
p2mp
disabled
p2mp_enabled will just render then p2mp command. Not sure that we should render the disabled command under p2mp or not.
cc: @ClausHolbechArista @gmuloc
|
MaheshGSLAB
reviewed
Nov 21, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/mpls.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/mpls-rsvp.j2
Outdated
Show resolved
Hide resolved
Comment on lines
+75
to
+77
| {% set with_neighbor_ipv4_address = mpls.rsvp.neighbors | selectattr('ip_address', 'arista.avd.defined') | arista.avd.natural_sort('ip_address') %} | ||
| {% set with_neighbor_ipv6_address = mpls.rsvp.neighbors | selectattr('ipv6_address', 'arista.avd.defined') | arista.avd.natural_sort('ipv6_address') %} | ||
| {% set sorted_ip_addresses = with_neighbor_ipv4_address | list + with_neighbor_ipv6_address | list %} |
There was a problem hiding this comment.
i dont think in doc we need to sort it. It is ok without sort also
There was a problem hiding this comment.
I understand, but it would be easy to read if they are sorted.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
changed the title
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for MPLS RSVP
Related Issue(s)
Fixes #https://github.com/aristanetworks/avd-internal/issues/149
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Adding MPLS RSVP support in eos_cli_config_gen
Checklist
Repository Checklist