Feat(eos_designs): Restrict PTP on certain uplinks #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4645
# Activate the virtual environment
source test-avd-pr-4645/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/sugetha24/ansible-avd.git@restrict-ptp-uplinks#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/sugetha24/ansible-avd.git#/ansible_collections/arista/avd/,restrict-ptp-uplinks --force
# Optional: Install AVD examples
cd test-avd-pr-4645
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
sugetha24
changed the title
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ptp.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_p2p_links.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
role: eos_cli_config_gen
sugetha24
force-pushed
the
restrict-ptp-uplinks
branch
3 times, most recently
from
be91a88
to
1a50a2d
Compare
sugetha24
force-pushed
the
restrict-ptp-uplinks
branch
from
1a50a2d
to
6136a7b
Compare
for more information, see https://pre-commit.ci
|
ClausHolbechArista
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Why are these configs changing?
| @@ -66,3 +66,21 @@ l3leaf: | |||
| sync: 14 | |||
| priority1: 40 | |||
| priority2: 1 | |||
|
|
|||
| - name: ptp-tests-restrict-uplinks-leaf1 | |||
There was a problem hiding this comment.
Please move this device out of the node_group where the two others are. This is why we see so many config changes, because the other devices are no longer forming an MLAG pair...
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Moving to draft. Please set ready for review once comments have been addressed and the PR has been rebased. Thanks. |
|
Make sure this is applied correctly for both l2leaf and l3leaf |
|
Is it a good idea to add ptp profiles to uplink_ptp in new issue/PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide a mechanism to control which uplinks are enabled for PTP.
Related Issue(s)
Fixes #4009
Component(s) name
arista.avd.eos_designsProposed changes node_groups:
How to test
molecule converge -s eos_designs_unit_tests -- --limit PTP_TESTSChecklist
Repository Checklist