Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(eos_cli_config_gen): Restructure molecule host vars #4694

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Nov 7, 2024

Change Summary

Restructure molecule host vars for below hosts:

  • management-accounts
  • management-api-http
  • management-cvx
  • management-api-models
  • management-gnmi
  • management-gnmi-new-flags
  • management-gnmi-grpc-tunnel
  • management-console
  • management-defaults
  • management-interfaces

Coverage

Template Coverage Details
Management-api-http 99% 1 partial
Management-api-gnmi 98% 4 partial
Management-api-models 98% 1 partial
Management-accounts 96% 1 partial
Management-console 96% 1 partial
Mangement-cvx 98% 1 partial
Management-defaults 100% -

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/171

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Restructure molecule host vars

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Nov 7, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4694
# Activate the virtual environment
source test-avd-pr-4694/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-1#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-1 --force
# Optional: Install AVD examples
cd test-avd-pr-4694
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 7, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Nov 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 7, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the refactor/molecule-1 branch 4 times, most recently from e54dea0 to 5b27356 Compare November 7, 2024 10:44
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Nov 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 8, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review November 8, 2024 14:54
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft November 12, 2024 06:46
@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Nov 12, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 18, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

…entory/host_vars/host1/management-api-http.yml

Co-authored-by: Guillaume Mulocher <[email protected]>
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 27, 2024
@gmuloc gmuloc merged commit 6813b26 into aristanetworks:devel Nov 27, 2024
49 checks passed
ClausHolbechArista pushed a commit to ClausHolbechArista/avd that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants