Feat(eos_cli_config_gen): Add interface traffic engineering and te admin group for ethernet/port-channel #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4754
# Activate the virtual environment
source test-avd-pr-4754/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/interface-te-admingrp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/interface-te-admingrp --force
# Optional: Install AVD examples
cd test-avd-pr-4754
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
MaheshGSLAB
reviewed
Nov 28, 2024
Comment on lines
+1206
to
+1208
| {% if ethernet_interface.traffic_engineering.administrative_groups is arista.avd.defined %} | ||
| traffic-engineering administrative-group {{ ethernet_interface.traffic_engineering.administrative_groups | join(",") }} | ||
| {% endif %} |
There was a problem hiding this comment.
Suggested change
| {% if ethernet_interface.traffic_engineering.administrative_groups is arista.avd.defined %} | |
| traffic-engineering administrative-group {{ ethernet_interface.traffic_engineering.administrative_groups | join(",") }} | |
| {% endif %} | |
| {% if ethernet_interface.traffic_engineering.administrative_groups is arista.avd.defined %} | |
| traffic-engineering administrative-group {{ ethernet_interface.traffic_engineering.administrative_groups | join(",") }} | |
| {% endif %} |
We can configure the administrative-group without just configure the only traffic-engineering in EOS. So we can remove the nested if.
| @@ -795,6 +795,23 @@ | |||
| | {{ sync_e_interface.name }} | {{ sync_e_interface.sync_e.priority | arista.avd.default('127') }} | | |||
| {% endfor %} | |||
| {% endif %} | |||
| {% set te_interfaces = [] %} | |||
| {% for ethernet_interface in ethernet_interfaces | arista.avd.natural_sort('name') %} | |||
| {% if ethernet_interface.traffic_engineering.enabled is arista.avd.defined(true) %} | |||
There was a problem hiding this comment.
Suggested change
| {% if ethernet_interface.traffic_engineering.enabled is arista.avd.defined(true) %} | |
| {% if ethernet_interface.traffic_engineering.enabled is arista.avd.defined(true) or traffic_engineering.administrative_groups is arista.avd.defined %} |
| description: Whether to enable traffic-engineering on this interface. | ||
| administrative_groups: | ||
| type: list | ||
| description: List of traffic-engineering administrative groups, valid values are names, ranges 0-127, or single integers 0-127. |
There was a problem hiding this comment.
It support hexadecimal too.
traffic-engineering administrative-group ?
<0x0-0xFFFFFFFF>,<0-127>,<0-127>-<0-127>,WORD Administrative Group value in
hexadecimal, range or name
format
| @@ -1201,6 +1201,12 @@ interface {{ ethernet_interface.name }} | |||
| {{ auth_failure_fallback_mba }} | |||
| {% endif %} | |||
| {% endif %} | |||
| {% if ethernet_interface.traffic_engineering.enabled is arista.avd.defined(true) %} | |||
There was a problem hiding this comment.
The order is not correct as per EOS. It should come between sync-e and link tracking group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds data model for interface traffic engineering and te admin groups for ethernet and port-channel interfaces.
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Adds the following data model to ethernet and port-channel interfaces:
Checklist
Repository Checklist