Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Added outlier elimination feature support for AVT profile #4762

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

Feat(eos_cli_config_gen): Added outlier elimination feature support for AVT profile #4762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5a3a97
added support for pathfinder outlier elimination
MaheshGSLAB Nov 26, 2024
56d840a
fix the pipe issue in doc j2 template
MaheshGSLAB Nov 26, 2024
175e534
run all molecule
MaheshGSLAB Nov 26, 2024
0dfb8b4
Merge branch 'devel' into issue-4240
MaheshGSLAB Nov 28, 2024
2639334
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2024
cd14a09
updated the j2 logic
Nov 28, 2024
6259c87
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ansible_collections/arista/avd/examples/cv-pathfinder/documentation/devices/pf1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,16 +542,16 @@ Topology role: pathfinder

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
20 changes: 10 additions & 10 deletions ansible_collections/arista/avd/examples/cv-pathfinder/documentation/devices/pf2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,16 +542,16 @@ Topology role: pathfinder

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
20 changes: 10 additions & 10 deletions ...llections/arista/avd/examples/cv-pathfinder/documentation/devices/site1-wan1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,16 +647,16 @@ Topology role: transit region

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
20 changes: 10 additions & 10 deletions ...llections/arista/avd/examples/cv-pathfinder/documentation/devices/site1-wan2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,16 +648,16 @@ Topology role: transit region

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
20 changes: 10 additions & 10 deletions ...llections/arista/avd/examples/cv-pathfinder/documentation/devices/site2-wan1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,16 +612,16 @@ Topology role: transit region

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
20 changes: 10 additions & 10 deletions ...llections/arista/avd/examples/cv-pathfinder/documentation/devices/site2-wan2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,16 +613,16 @@ Topology role: transit region

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-CRITICAL-SECRET-DATA | LB-RED-POLICY-CRITICAL-SECRET-DATA | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
18 changes: 9 additions & 9 deletions ...llections/arista/avd/examples/cv-pathfinder/documentation/devices/site3-wan1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,15 +596,15 @@ Topology role: edge

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| BLUE-POLICY-DEFAULT | LB-BLUE-POLICY-DEFAULT | - | - | - | - | - | - |
| BLUE-POLICY-VIDEO | LB-BLUE-POLICY-VIDEO | - | - | - | - | - | - |
| BLUE-POLICY-VOICE | LB-BLUE-POLICY-VOICE | - | - | - | - | - | - |
| DEFAULT-POLICY-CONTROL-PLANE | LB-DEFAULT-POLICY-CONTROL-PLANE | - | - | - | - | - | - |
| DEFAULT-POLICY-DEFAULT | LB-DEFAULT-POLICY-DEFAULT | - | - | - | - | - | - |
| RED-POLICY-NORMAL-DATA | LB-RED-POLICY-NORMAL-DATA | - | - | - | - | - | - |
| RED-POLICY-NOT-SO-IMPORTANT-DATA | LB-RED-POLICY-NOT-SO-IMPORTANT-DATA | - | - | - | - | - | - |

#### AVT Policies

Expand Down
21 changes: 15 additions & 6 deletions ...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5645,12 +5645,12 @@ Topology role: pathfinder

#### AVT Profiles

| Profile name | Load balance policy | Internet exit policy |
| ------------ | ------------------- | -------------------- |
| office365 | - | - |
| scavenger | scavenger-lb | scavenger-ie |
| video | - | video-ie |
| voice | voice-lb | - |
| Profile name | Load balance policy | Internet exit policy | Metric Order | Jitter Threshold | Latency Threshold | Load Percentage | Loss-rate Percentage |
| ------------ | ------------------- | -------------------- | ------------ | ---------------- | ----------------- | --------------- | -------------------- |
| office365 | - | - | - | - | - | - | - |
| scavenger | scavenger-lb | scavenger-ie | latency | 200 | 100 | 25.16 | 20 |
| video | - | video-ie | - | - | 100 | - | - |
| voice | voice-lb | - | - | 100 | - | - | - |

#### AVT Policies

Expand Down Expand Up @@ -5718,12 +5718,21 @@ router adaptive-virtual-topology
profile scavenger
internet-exit policy scavenger-ie
path-selection load-balance scavenger-lb
metric order latency
path-selection outlier elimination threshold latency 100 milliseconds
path-selection outlier elimination threshold jitter 200 milliseconds
path-selection outlier elimination threshold loss-rate 20 percent
path-selection outlier elimination threshold load 25.16 percent
!
profile video
internet-exit policy video-ie
path-selection outlier elimination disabled
path-selection outlier elimination threshold latency 100 milliseconds
!
profile voice
path-selection load-balance voice-lb
path-selection outlier elimination
path-selection outlier elimination threshold jitter 100 milliseconds
!
vrf blue
avt profile video id 1
Expand Down
9 changes: 9 additions & 0 deletions ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,12 +381,21 @@ router adaptive-virtual-topology
profile scavenger
internet-exit policy scavenger-ie
path-selection load-balance scavenger-lb
metric order latency
path-selection outlier elimination threshold latency 100 milliseconds
path-selection outlier elimination threshold jitter 200 milliseconds
path-selection outlier elimination threshold loss-rate 20 percent
path-selection outlier elimination threshold load 25.16 percent
!
profile video
internet-exit policy video-ie
path-selection outlier elimination disabled
path-selection outlier elimination threshold latency 100 milliseconds
!
profile voice
path-selection load-balance voice-lb
path-selection outlier elimination
path-selection outlier elimination threshold jitter 100 milliseconds
!
vrf blue
avt profile video id 1
Expand Down
15 changes: 15 additions & 0 deletions ...olecule/eos_cli_config_gen/inventory/host_vars/host1/router-adaptive-virtual-topology.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,25 @@ router_adaptive_virtual_topology:
# Out of order to test sorting
- name: voice
load_balance_policy: voice-lb
outlier_elimination:
enabled: true
threshold:
jitter: 100
- name: video
internet_exit_policy: video-ie
outlier_elimination:
enabled: false
threshold:
latency: 100
- name: office365
- name: scavenger
outlier_elimination:
threshold:
latency: 100
jitter: 200
load: 25.16
loss_rate: 20
metric_order: latency
load_balance_policy: scavenger-lb
internet_exit_policy: scavenger-ie
policies:
Expand Down
32 changes: 32 additions & 0 deletions ...ta/avd/roles/eos_cli_config_gen/docs/tables/router-adaptive-virtual-topology.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading