-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for configuring dhcp server ipv4
and dhcp server ipv6
for Port-Channel interfaces
#4885
Feat(eos_cli_config_gen): Add support for configuring dhcp server ipv4
and dhcp server ipv6
for Port-Channel interfaces
#4885
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4885
# Activate the virtual environment
source test-avd-pr-4885/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@dhcp_server_ipv4_#4875#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,dhcp_server_ipv4_#4875 --force
# Optional: Install AVD examples
cd test-avd-pr-4885
ansible-playbook arista.avd.install_examples |
Need to correct PR title and also I think it would be better to add dhcp_server_ipv6 also. |
dhcp sever ipv4
for a Port-Channel interface
dhcp sever ipv4
for a Port-Channel interfacedhcp server ipv4
for a Port-Channel interface
dhcp server ipv4
for a Port-Channel interfacedhcp server ipv4
for Port-Channel interfaces
@Shivani-gslab - if this merges after #4752 we will need to update the configuration there |
ba68794
to
79f4cca
Compare
@gmuloc shall I add |
dhcp server ipv4
for Port-Channel interfacesdhcp server ipv4
and dhcp server ipv6
for Port-Channel interfaces
eb01803
to
8156912
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/dhcp-servers.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/dhcp-servers.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/dhcp-servers.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
{% for ethernet_interface in ethernet_interfaces_dhcp_server | arista.avd.natural_sort %} | ||
| {{ ethernet_interface.name }} | {{ ethernet_interface.dhcp_server_ipv4 | arista.avd.default(false) }} | {{ ethernet_interface.dhcp_server_ipv6 | arista.avd.default(false) }} | | ||
{% endfor %} | ||
{% if ethernet_interfaces_dhcp_server | length > 0 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if
is not needed. The for loop would just not loop if the list is empty. Same for v6
Change Summary
Add support for configuring
dhcp server ipv4
anddhcp server ipv6
for Port-Channel interfacesRelated Issue(s)
Fixes #4875
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding new key
dhcp_server_ipv4
under port-channel-interfaces.How to test
Test added in molecule, verify the EOS CLI
Checklist
User Checklist
Repository Checklist