Change dependecy list to arch specific dependecies #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manith-arista
force-pushed
the
manith-archDeps
branch
from
eeea003
to
0742a9a
Compare
aajith-arista
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Pls add some changes to sanityCheck in manifest.go to make sure
- Keys are valid (all, three archs )
- If all is there no other keys are there
Indexing should take of arm too
We might no specify target for arm. So it will be empty, but if you run arch it will say aarch64/arm64.
Pls make sure test covers target unspecified and target specified(i686) cases.
manith-arista
force-pushed
the
manith-archDeps
branch
from
aa0f428
to
e81d377
Compare
aajith-arista
previously approved these changes
Mar 22, 2024
manith-arista
force-pushed
the
manith-archDeps
branch
from
e81d377
to
19b29bd
Compare
Change dependecy list to arch specific dependecies Currently we support eext packages to specify a list of dependecies for the package. Some packages reqiure the dependecies only for a specific arch (since dependecies for other archs are available upstream). Hence we support arch specific dependecies for eext packages, allowed archs are 'i686', 'x86_64' and 'all'(both) Added documentation and checks for dependencies Updated the dependencies docstring with additional details for usage. Added checks to ensure dependencies and not duplicated across archs, and only valid arch is provided as argument. Updated supported test cases to cover all arch dependency cases. Fixes: BUG908812
manith-arista
force-pushed
the
manith-archDeps
branch
from
19b29bd
to
86bb1a2
Compare
aajith-arista
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we support eext packages to specify a list of dependecies for the package. Some packages reqiure the dependecies only for a specific arch (since dependecies for other archs are available upstream). Hence we support arch specific dependecies for eext packages, allowed archs are 'i686', 'x86_64' and 'all'(both)
Fixes: BUG908812