Add fedora repo support for eext #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some rpms can be distributed in multiple repos, hence we need to specify priority to the repo for eext to decide where to pick dependencies from. Priority 1 (highest) is given to the local deps available for eext to check before checking upstream repos. The priority should be defined at a repo-bundle level in dnfconfig.yaml, with a priorty > 1. Or within the package specific eext.yaml file at a repo specific level. This is an optional flag, the default priority is assigned by the repo-bundle.
eext packages have a dependency on Fedora distro rpms. Adding these rpms to eext was cumbersome due to the number of new rpms introduced. Instead we will satisfy Fedora dependencies through a new repo bundle, fc40-unsafe and create a snapshot fc40-snapshot to ensure build reproducibility. fc40-unsafe is a local cache of the required dependencies pulled in from upstream by eext. eext developers snapshot this repo when requested by repo owners to pull in fedora dependencies.
manith-arista
force-pushed
the
manith.fedora-support
branch
from
aaa7368 to
9457d96
Compare
aajith-arista
requested changes
Jul 25, 2024
Update code to add check for negative priority that could be provided by the user.
aajith-arista
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few eext packages have dependency on fedora distribution. We can resolve the dependencies by creating eext packages for these package, but that will result in unnecessary creation of a lot of upstream packages.
Instead we intend to provide these dependencies through a fc40 repo snapshot. We have created 2 new repo-bundles:
As part of this feature, we also need to add priority to each repo-bundle, since we want fedora repos to have lowest priority (fc40 should be the last resort to satisfy a dependency, if we find it elsewhere, get it from there). We define repo-bundle level priority in dnfconfig.yaml and allow users to override priority at repo level in their respective eext.yaml.