Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue that was noted in #35. When connecting locally from the US east coast to a switch in Singapore my connections would pile up. However, when connecting to a switch in New York, I did not run into the issue.
Using the debugging from the issue:
I saw every time I ran a command a new connection would be created, but the connection would stay around, building up connections, and goroutines. When timing these calls, the would take between 2-7 seconds:
When connecting to switches in NY, these were all under 1 second, and the connections would immediately clear up, and we had no pile up of goroutines
Adding the
DisableKeepAlive
option cleared up the connections immediately after they were complete.