DisplayInfo の format を用いて devtoolsでの表示を指定する #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -117,7 +117,7 @@ pub struct FieldIter<'a> { | |||
| } | |||
|
|
|||
| impl<'a> Iterator for FieldIter<'a> { | |||
| type Item = Result<(&'a str, FieldSchema)>; | |||
| type Item = Result<(&'a str, &'a tlmdb::DisplayInfo, FieldSchema)>; | |||
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
cannot find type DisplayInfo in module tlmdb
| @@ -131,10 +131,11 @@ fn build_field_schema( | |||
| obs: tlmdb::OnboardSoftwareInfo, | |||
| field: &tlmdb::Field, | |||
| bit_range: Range<usize>, | |||
| ) -> Result<(&str, FieldSchema)> { | |||
| ) -> Result<(&str, &tlmdb::DisplayInfo, FieldSchema)> { | |||
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
cannot find type DisplayInfo in module tlmdb
| let converter = build_integral_converter(&field.conversion_info); | ||
| Ok(( | ||
| &field.name, | ||
| &field.display_info, |
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
no field display_info on type &tlmcmddb::tlm::Field
kobkaz
force-pushed
the
display_info
branch
2 times, most recently
from
fdc6796
to
cb67b15
Compare
kobkaz
force-pushed
the
display_info
branch
3 times, most recently
from
17bd1ed
to
84bbb2c
Compare
kobkaz
force-pushed
the
display_info
branch
2 times, most recently
from
590607f
to
934f39d
Compare
|
ビルドこれでいいのか感はあるので @sksat に見てほしい |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47 display info のうちformatに対応する
interpolatorの仕様上位置引数は使えなさそうなので、暗黙に
valueという変数として扱うdisplay info の format は
{value:#0X}のようになる