Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove surf & move to reqwest #267

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Remove surf & move to reqwest #267

merged 2 commits into from
Oct 30, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 30, 2024

@sksat sksat self-assigned this Oct 30, 2024
github-actions[bot]
github-actions bot reviewed Oct 30, 2024
View reviewed changes
src/slack.rs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] <dead_code> reported by reviewdog 🐶
variants Warning, Danger, Merged, and Closed are never constructed

hubhook/src/slack.rs

Line 31 in e2af2ff

pub enum Color {

github-actions[bot]
github-actions bot reviewed Oct 30, 2024
View reviewed changes
src/slack.rs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] <dead_code> reported by reviewdog 🐶
associated function from_string is never used

hubhook/src/slack.rs

Line 45 in e2af2ff

impl Message {

@sksat sksat added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit f789145 Oct 30, 2024
1 check passed
@sksat sksat deleted the remove-surf branch October 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@sksat sksat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sksat