Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flake8-requirements self-checking to CI #87

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Added flake8-requirements self-checking to CI #87

merged 4 commits into from
Feb 20, 2024

Conversation

jamesbraza
Copy link
Contributor

#86 would have introduced a bug, but CI did not capture the bug.

This PR ensures CI will catch this issue.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0061d9a) 93.29% compared to head (6536f44) 93.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files           3        3           
  Lines         388      388           
=======================================
  Hits          362      362           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesbraza jamesbraza changed the title Added flake8 invocation to CI Added flake8-requirements self-checking to CI Feb 20, 2024
@jamesbraza
Copy link
Contributor Author

Please see the last two commits (removal of tomli, then reverting it), it shows this PR works

Cc @arkq for review

setup.cfg Show resolved Hide resolved
@arkq arkq merged commit f36956e into arkq:master Feb 20, 2024
7 checks passed
@jamesbraza jamesbraza deleted the self-inspection-in-ci branch February 20, 2024 18:54
arkq pushed a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants