Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct docs path for references #601

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: correct docs path for references #601

merged 1 commit into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. fix: correct docs host and path for API references 

    The Stripe documentation now is hosted on https://docs.stripe.com/api. The old https://stripe.com/docs/api still works but gets redirected to the new one.
The issue is with how we use to generate documentation link on url_finder.rs. On that file, we look for the load the docs and find the window.__INITIAL_STATE__, which contains relative links to the resources.
We are using those relative links as if they were relative from https://stripe.com, but now they are relative from https://docs.stripe.com  which causes the links to not be correctly built.
This is the issue that is causing the verify-codegen CI job to fail.
By updating it to the right path, it should stop generating incorrect path to the docs.
    @augustoccesar
    augustoccesar committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    539836d View commit details
    Browse the repository at this point in the history