-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jg/wdk2023 tweaks - bring the available features on par with current development #6091
Conversation
add config with Gunyah enabled Signed-off-by: Jens Glathe <[email protected]>
Signed-off-by: Jens Glathe <[email protected]>
Signed-off-by: Jens Glathe <[email protected]>
This seems to be
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could please address the comment above?
Hmm. x13s shouldn't be touched by my changes, it has it's own .wip file...? Also, branch and target are separate.
The board-2.bin is hacked up with qca-swiss-army-knife, I added entries with the best matching calibration data and board identifiers as calculated by the ath11k driver. There are calibration data for the WDK in the Windows drivers (I hoped), but wasn't able to extract and make use of them - so I used the ones of the x13s, which appear to be best match after testing all of them (and work well enough). So... this isn't the version that linux-firmware would install, which runs perfectly with my x13s btw... why do you have a separate one in armbian-firmware? This aside, as linux-firmware sometimes is updated and would overwrite the hacked-up file, would be a good idea to put these files into |
But, you're changing https://github.com/armbian/build/commits/main/config/kernel/linux-arm64-sc8280xp.config |
Oops, sorry. I will put a separate config file for the wdk, didn't want to change the x13s target. The config should work for both hardwares, though. My branch runs on both just by providing the dtb. |
Signed-off-by: Jens Glathe <[email protected]>
Signed-off-by: Jens Glathe <[email protected]>
Should be in shape now, hard to test with firmware in armbian/firmware #73. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's merge this. I will soon change the x13s and this wdk2023 into proper family for the sc8280xp's -- that way we can have current/edge for each and try and reuse as much code as possible.
The firmware stuff needs review at the x13s level as well, I guess we can both use the same firmware in the end. I'd also love to not depend on the whole firmware-full if possible.
Description
This PR adds some tweaks to get the current (and IMO best possible yet) configuration of the WDK.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh build BOARD=wdk2023 BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED='3dsupport browsers chat desktop_tools editors email internet multimedia office programming remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=mantic
Checklist: