Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the Rock S0 CMA to match Rock PI-S + include fixMACaddress script #7522

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

brentr
Copy link
Collaborator

@brentr brentr commented Nov 28, 2024

in the S0 image to assign end0 MAC address from CPU serial #
in case running U-Boot earlier than 2024.10

Description

Correct misleading comments in /etc/udev/rules.d/05-fixMACaddress.rules
Add fixMACaddress script to Rock S0 image

Jira

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • build and verified new S0 image still works and contains fixMACaddress script

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Include the tiny fixMACaddress script in the S0 image
to assign end0 MAC address from CPU serial #
in case running U-Boot earlier than 2024.10
@brentr brentr self-assigned this Nov 28, 2024
@brentr brentr requested a review from a team as a code owner November 28, 2024 07:16
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... BSP Board Support Packages labels Nov 28, 2024
@brentr
Copy link
Collaborator Author

brentr commented Nov 28, 2024

@paolosabatino
Could you please review this?
I've added the CMA reduction to the S0. The performance hit is hard to quantify, so, for now, we'll stick withe the 16MB size. (The increase in free RAM is very quantifiable)

@brentr brentr requested a review from paolosabatino November 28, 2024 07:21
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release labels Nov 28, 2024
@brentr brentr merged commit a1fa664 into armbian:main Nov 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release BSP Board Support Packages Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants