-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Google Cloud Storage API (4.7.0) and security fixes #21
Open
alexandre-steinberg
wants to merge
62
commits into
arozar:master
Choose a base branch
from
alexandre-steinberg:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: working and tested library Date: Wed Apr 22 11:44:47 2020 -0300 Changes to be committed: modified: .gitignore new file: jest.config.js modified: lib/index.d.ts modified: lib/index.js modified: lib/index.js.map renamed: lib/index.test.d.ts -> lib/index.spec.d.ts new file: lib/index.spec.js new file: lib/index.spec.js.map deleted: lib/index.test.js deleted: lib/index.test.js.map modified: package-lock.json modified: package.json new file: src/index.spec.ts deleted: src/index.test.ts modified: src/index.ts
Date: Sun Apr 26 21:44:24 2020 -0300 Changes to be committed: deleted: .travis.yml modified: CHANGELOG.md new file: LICENSE.md modified: README.md modified: lib/index.js modified: lib/index.js.map modified: package-lock.json modified: package.json modified: src/index.ts
Other modules also updated to their latest versions
Add mising params in StorageEngine's constructor
modified: CHANGELOG.md modified: package-lock.json modified: package.json
add missing constructor parameter
Update index.d.ts
Hi, have given you access to the repo so you can integrate this if you're happy with the work. |
…or buckets where `uniformBucketLevelAccess` is enabled.
fixup!: Include the other build files. fixup! fixup!
Multi-file upload now works correctly
`uniformBucketLevelAccess` enabled support
fix(auth): Allow credentials OR keyFileName
fix(linkUrl): Swap cloud.google.com to storage.googleapis.com
@alexandre-steinberg can you merge this PR? |
Fix/ invoke callback on file removed
Update Packages for Multer
…instansiating Storage
Remove unnecessary constraint where creds or keyfile is required for …
Add prepare script
feat: allow arbitrary StorageOptions to be passed into Storage client
Add support for optional filenameEncoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Update to latest Google Cloud Storage API (4.7.0)
Update to latest multer (1.4.2)
Update on dependencies for security fixes
Breaking changes
Drop support for Node.js < 8
If accepted, I'd suggest to update version to 2.0.0 due to breaking changes.