Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Ocean Terraform code to create multiple instances in multiple… #237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dddbbbsss
Copy link

This module creates a number of servers in each of provided region. If you set count = 2 and regions = ["nyc1", "nyc2", "nyc3"] this will create six servers total. Two servers in each of regions. See readme.txt for more details.

… regions with SystemD provisioned for db1000n
@dddbbbsss dddbbbsss requested a review from arriven as a code owner March 8, 2022 16:36
@arriven arriven added the triage needed This issue/PR needs to be checked by someone to confirm it's correct label Mar 8, 2022
@arriven
Copy link
Owner

arriven commented Mar 8, 2022

as discussed somewhere previously - can you please get someone (ideally at least 2 people) to validate your instruction and modules before I merge it?

@dddbbbsss
Copy link
Author

Unfortunately, I can't ask someone to validate. But it is easy read code without any hidden catch.

@arriven
Copy link
Owner

arriven commented Mar 9, 2022

I don't mean to indicate your code might be doing something suspicious, just that I'm trying to test every change going in the repo to improve stability but in order to test out changes to cloud modules I need to go through the process of setting up the account on DO and doing all other required steps (it takes time and I don't have a lot of it these days for obvious reasons). I ask people to have someone validate their instructions just to save some time on that

" | tee /etc/systemd/system/pings.service

cd /opt
wget https://github.com/Arriven/db1000n/releases/download/v0.5.20/db1000n-v0.5.20-linux-amd64.tar.gz --output-document=/opt/db1000n-linux-amd64.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will deploy a hardcoded version of the app. maybe would be better to download the latest version?
same for script below

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works for me. Of course the code could have error, however I will maintain the code until all possible bug disappear and manual will be easy to understand.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will deploy a hardcoded version of the app. maybe would be better to download the latest version? same for script below

I have fixed it my_repo, but i can't update pull request here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works for me.

but if you push with a hardcoded version then it requires maintaining or it will be dead code after several releases

but i can't update pull request here.

you can just push new code to the same branch

Copy link
Author

@dddbbbsss dddbbbsss Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just push new code to the same branch

I can't. Even the branch has fixed code, I have seen: Your branch is up to date with 'origin/db1000n'.

monitoring = true
droplet_agent = true
tags = "stop-sites"
digitalocean_ssh_key = "ssh_user_key_name"
Copy link
Contributor

@arfgdev arfgdev Mar 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it to digitalocean_ssh_key variables.

@arfgdev
Copy link
Contributor

arfgdev commented Mar 13, 2022

I have tried to run it but got

tag not found: GET https://api.digitalocean.com/v2/tags/stop-sites: 404 (request "xxxxxx-17e5-4dca-bf45-xxxxxxx") The resource you were accessing could not be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage needed This issue/PR needs to be checked by someone to confirm it's correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants