Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #22

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Documentation #22

wants to merge 8 commits into from

Conversation

1Jajen1
Copy link
Member

@1Jajen1 1Jajen1 commented Jul 9, 2020

I decided to finally start documentation for this. I expect this to take about 1-4 weeks depending on how well preparing for exams goes.

Reviews are much appreciated at any point in time as writing docs is not something I do a lot of^^

Oh and with this there are only a few other tasks to go to make this library fully usable:

  • Provide interface with arrow-fx-coroutines or switch to using it directly
  • Update kotest in the kotlintest module

Nice to have:

  • merge Test core functionality #7 or better even split it and incrementally improve testing. This should only be done after updating kotlintest and deciding on what to do with arrow-fx-coroutines

@1Jajen1
Copy link
Member Author

1Jajen1 commented Jul 9, 2020

@rachelcarmena Is this way of structuring documentation correct or is there something else that I need to do?

@nomisRev
Copy link
Member

nomisRev commented Jul 9, 2020

I decided to finally start documentation for this. I expect this to take about 1-4 weeks depending on how well preparing for exams goes.

Very excited about this library in the Kotlin eco-system! 👏 👏
And good luck with your exams @1Jajen1! 🤞🙌

@rachelcarmena
Copy link
Member

@rachelcarmena Is this way of structuring documentation correct or is there something else that I need to do?

Thanks @1Jajen1 !! It look very good to me.

Then it will be necessary to add these pages into the website sidebar menu: https://github.com/arrow-kt/arrow-site#how-to-add-a-menu-entry

By the way, arrow-docs project is configured and the API is being generated and validated. However, you can see this result now:

> Task :arrow-docs:runAnk
      :::     ::::    ::: :::    :::
    :+: :+:   :+:+:   :+: :+:   :+:
   +:+   +:+  :+:+:+  +:+ +:+  +:+
  +#+     ++: +#+ +:+ +#+ +#++:++
  +#+     +#+ +#+  +#+#+# +#+  +#+
  #+#     #+# #+#   #+#+# #+#   #+#
  ###     ### ###    #### ###    ###
Current heap used: 6.6 MiB
Starting ank with Heap Size: 184.0 MiB, Max Heap Size: 2.7 GiB
Ank Processed 0 files

because there aren't code snippets to validate because of using:

```kotlin

instead of:

```kotlin:ank

You can find more details in this guide: https://github.com/arrow-kt/arrow/blob/master/docs/libraries/how-to-generate-and-validate-documentation.md

Despite the links, please, let me know if I can help you 🙌

@1Jajen1 1Jajen1 changed the title Quickstart readme and first document Documentation Jul 9, 2020
@1Jajen1
Copy link
Member Author

1Jajen1 commented Jul 9, 2020

And good luck with your exams @1Jajen1!

🙈 Worst ones are over so... :)

By the way, arrow-docs project is configured and the API is being generated and validated. However, you can see this result now

Yeah ank is definitely a goal. I need to change some config stuff so that ank will run the no-color version and find a good layout option for the output. This is all trivially tweakable, all it needs is a good way of hiding it from docs.

Then it will be necessary to add these pages into the website sidebar menu: https://github.com/arrow-kt/arrow-site#how-to-add-a-menu-entry

I was not aware that we have documentation for our documentation! (Bad puns aside, this is great, especially the ability to locally run it. And I am sure you have mentioned this before somewhere as well and I just keep forgetting 🙈 )

Comment on lines 38 to 55
```
(2, 2)
|-> (0, 2)
| |-> (0, 0)
| --> (0, 1)
| --> (0, 0)
|-> (1, 2)
| |-> (0, 2)
| | |-> (0, 0)
| | --> (0, 1)
| | --> (0, 0)
| |-> (1, 0)
| --> (1, 1)
| --> (1, 0)
|-> (2, 0)
--> (2, 1)
--> (2, 0)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1Jajen1 🙌 Just a comment about this console output. Website provides the execution for the code snippets with kotlin:ank:playground. Thanks!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that modifier is missing in Ank documentation... 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used that quite a bit in arrow documentation, just forgot that this was available here as well. Thanks for the reminder :)

That does mean I need to tweak the second generators seed to produce (2,2) as well so that it won't time out on the amount of output.

Even (2,4) produces such a large shrink tree that it will likely time out. (Which is good because it is supposed to have a large shrink tree)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1Jajen1 !! 🙌

@1Jajen1
Copy link
Member Author

1Jajen1 commented Aug 26, 2020

I got side-tracked with all the continuation stuff and stm... Time to pick this up again^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants