-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #22
base: main
Are you sure you want to change the base?
Documentation #22
Conversation
@rachelcarmena Is this way of structuring documentation correct or is there something else that I need to do? |
Very excited about this library in the Kotlin eco-system! 👏 👏 |
Thanks @1Jajen1 !! It look very good to me. Then it will be necessary to add these pages into the website sidebar menu: https://github.com/arrow-kt/arrow-site#how-to-add-a-menu-entry By the way,
because there aren't code snippets to validate because of using:
instead of:
You can find more details in this guide: https://github.com/arrow-kt/arrow/blob/master/docs/libraries/how-to-generate-and-validate-documentation.md Despite the links, please, let me know if I can help you 🙌 |
🙈 Worst ones are over so... :)
Yeah ank is definitely a goal. I need to change some config stuff so that ank will run the no-color version and find a good layout option for the output. This is all trivially tweakable, all it needs is a good way of hiding it from docs.
I was not aware that we have documentation for our documentation! (Bad puns aside, this is great, especially the ability to locally run it. And I am sure you have mentioned this before somewhere as well and I just keep forgetting 🙈 ) |
Writeup of caveats when defining generators
Some points at where arrow-check is better than other prop testing libs
``` | ||
(2, 2) | ||
|-> (0, 2) | ||
| |-> (0, 0) | ||
| --> (0, 1) | ||
| --> (0, 0) | ||
|-> (1, 2) | ||
| |-> (0, 2) | ||
| | |-> (0, 0) | ||
| | --> (0, 1) | ||
| | --> (0, 0) | ||
| |-> (1, 0) | ||
| --> (1, 1) | ||
| --> (1, 0) | ||
|-> (2, 0) | ||
--> (2, 1) | ||
--> (2, 0) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @1Jajen1 🙌 Just a comment about this console output. Website provides the execution for the code snippets with kotlin:ank:playground
. Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that modifier is missing in Ank documentation... 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used that quite a bit in arrow documentation, just forgot that this was available here as well. Thanks for the reminder :)
That does mean I need to tweak the second generators seed to produce (2,2) as well so that it won't time out on the amount of output.
Even (2,4) produces such a large shrink tree that it will likely time out. (Which is good because it is supposed to have a large shrink tree)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @1Jajen1 !! 🙌
I got side-tracked with all the continuation stuff and stm... Time to pick this up again^^ |
I decided to finally start documentation for this. I expect this to take about 1-4 weeks depending on how well preparing for exams goes.
Reviews are much appreciated at any point in time as writing docs is not something I do a lot of^^
Oh and with this there are only a few other tasks to go to make this library fully usable:
Nice to have: