-
Notifications
You must be signed in to change notification settings - Fork 29
Enable incremental annotation processing #153
Conversation
compileOnly "com.google.auto.service:auto-service:$GOOGLE_AUTO_SERVICE_VERSION" | ||
kapt "com.google.auto.service:auto-service:$GOOGLE_AUTO_SERVICE_VERSION" | ||
compileOnly "com.google.auto.service:auto-service:1.0-rc7" | ||
kapt "com.google.auto.service:auto-service:1.0-rc7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this awesome PR @hadilq 🙌 I was thinking about this kind of changes and I think the mistake was to locate all the versions in a centralized place without filtering them.
I mean, in this case, GOOGLE_AUTO_SERVICE_VERSION
(and GOOGLE_COMPILE_TESTING_VERSION
as well) is just being used in this repository so I think it doesn't make sense to be placed in arrow
repository.
So please, feel free to locate those versions in this repository and remove them from arrow
repository.
I think arrow
repository should contain versions that are relevant and can impact to all the libraries. What do you think about it?
Thanks again @hadilq !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rachelcarmena for this great suggestion. I'm totally agree and you can find the changes in b8d1703 and arrow-kt/arrow#2158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @hadilq for your contribution!!
Hi everyone! It took more than two weeks to review it. Please feel free to give me some feedback. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hadilq,
Sorry for the late response. Not many contributors have experience in the old Arrow-Meta implementation, so not many reviewers available.
This looks good to me, and would great to have for a last 0.11.0
release which will still rely on this. Also for working on Arrow that'll be great! So thanks a lot for this contribution :)
cc\ @raulraja could you also give this a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hadilq ! As you may now soon we will retire kapt for meta and as Simon pointed out there is not many people in this area to review.
This PR is created after arrow-kt/arrow#2032 issue to enable incremental annotation processing. The following is the list of assumptions and changes.
auto-service
to1.0-rc7
where based on Support incremental annotation processing google/auto#615 must support incremental annotation processing. We may need to create a PR for https://github.com/arrow-kt/arrow to update theGOOGLE_AUTO_SERVICE_VERSION
value,File
instead ofFiler
when thepackageName
contains Java keywords likeconst
ortry
FilerException: Attempt to reopen a file for path ...
kapt.incremental.apt=true
line togradle.properties
files.