Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adapt the name of the function according to the recent edits. The new name was just not applied to sdf_to_nsjon...
Interrogation about a possible improvement:
Makes me think about something, what about including checks in CI to test the full pipeline ? I know it will take time but maybe it would only be necessary to merge from dev to a new "master/main" branch. I haven't thought about all the details about this kind CI checks but it could avoid us using version of NCK in which don't work... I had to made test manually and correct these to make sure the new NCK we're going to use would work, I think this kind of feature could be an interesting improvement.
If you guys agree and if you think this is doable I will write a new issue.