Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : corrected unworking storageobject_reader #99

Merged
merged 7 commits into from
Feb 26, 2021
Merged

fix : corrected unworking storageobject_reader #99

merged 7 commits into from
Feb 26, 2021

Conversation

louisRDSC
Copy link
Contributor

@louisRDSC louisRDSC commented Feb 10, 2021 •
edited by bibimorlet
Loading

Issue

Description

  • #removed broken and useless code in nck/readers/objectstorage_reader.py,
  • Created njson reader in nck/utils/file_reader.py
  • Moved reader factory from nck/readers/objectstorage_reader.py to nck/utils/file_reader .

@louisRDSC louisRDSC self-assigned this Feb 10, 2021
@gabrielleberanger
Copy link
Contributor

Good job, thank you Louis ! 👍

Did you also have the chance to test the S3 reader ? If needed, I believe that you can ask @tom-grivaud for temporary accesses, as he is working on a project deployed on AWS.

@bibimorlet
Copy link
Contributor

Hey
I tried this new version of the reader, good job.

There are two things I'd like to discuss with you:

  • If think that the config.project_id in the GCSReader could be removed. We could for example call the project_id with a new click_parameter or another way.
  • Can you add some tests for your reader? in order to check if all the desired use cases are validated.

Thanks 😃

bibimorlet
bibimorlet suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@bibimorlet bibimorlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we add some tests?

benoitgoujon
benoitgoujon approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@benoitgoujon benoitgoujon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bibimorlet
bibimorlet approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@bibimorlet bibimorlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine for me, Thanks!

@louisRDSC louisRDSC merged commit a9b7e3e into dev Feb 26, 2021
@louisRDSC louisRDSC deleted the improve-gcs-reader branch February 26, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgoujon benoitgoujon benoitgoujon approved these changes

@bibimorlet bibimorlet bibimorlet approved these changes

@gabrielleberanger gabrielleberanger Awaiting requested review from gabrielleberanger

Assignees

@louisRDSC louisRDSC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG - Fix GCS Reader (deprecated)
4 participants
@louisRDSC @gabrielleberanger @bibimorlet @benoitgoujon