Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of README (do not merge!) #30

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Review of README (do not merge!) #30

merged 4 commits into from
Feb 22, 2024

Conversation

luca-serra
Copy link
Contributor

Description of the goal of the PR

Description:

Changes this PR introduces (fill it before implementation)

  • : Change 1
  • : Change 2

Checklist before requesting a review

  • I have commented my code, particularly in hard-to-understand areas
  • I have typed my code
  • I have created / updated the docstrings
  • I have updated the README, if relevant
  • I have updated the requirements files if a new package is used
  • I have tested my code
  • The CI pipeline passes
  • I have performed a self-review of my code

Copy link
Contributor Author

@luca-serra luca-serra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très clean le README !

README_review.md Outdated Show resolved Hide resolved
README_review.md Outdated Show resolved Hide resolved
README_review.md Outdated Show resolved Hide resolved
README_review.md Outdated Show resolved Hide resolved
README_review.md Outdated Show resolved Hide resolved
@VincentAuriau VincentAuriau merged commit 6828b81 into main Feb 22, 2024
3 checks passed
@VincentAuriau VincentAuriau deleted the review-readme branch February 22, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants