Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release to artifact registry #85

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

julesbertrand
Copy link
Collaborator

Description

Releases should be made to an Artifact Registry repository to avoid the GCS bucket overhead.

Related Issue

Type of Change

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🔐 Security fix
  • 📚 Examples / docs / tutorials / dependencies update
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make format-code.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • If my change requires a change to docs, I have updated the documentation accordingly.

Copy link

github-actions bot commented Nov 6, 2023

PR Analysis

  • 🎯 Main theme: The main theme of this PR is to change the release process from Google Cloud Storage to Google Artifact Registry.
  • 📝 PR summary: This PR modifies the CI/CD pipeline to upload the build artifacts to Google Artifact Registry instead of Google Cloud Storage. This change is made to avoid the overhead of Google Cloud Storage. The changes are made in the .github/workflows/release.yaml file.
  • 📌 Type of PR: Improvement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, The PR is straightforward and involves changes in the CI/CD pipeline. It does not involve complex logic or large code changes.
  • 🔒 Security concerns: No

PR Feedback

  • 💡 General suggestions: The PR seems to be well-structured and follows the best practices of CI/CD. However, it would be beneficial to add a rollback mechanism in case the upload to the Artifact Registry fails. Also, consider adding error handling and logging for the new steps added in the pipeline.

  • 🤖 Code feedback:

    • relevant file: .github/workflows/release.yaml
      suggestion: Consider adding a step to delete the artifacts from the workspace after they have been successfully uploaded to the Artifact Registry. This will help in maintaining a clean workspace for future runs. [medium]
      relevant line: - name: Upload to Google Artifact Registry

    • relevant file: .github/workflows/release.yaml
      suggestion: It would be beneficial to add a step to verify the successful upload of the artifacts to the Artifact Registry. This can be done by listing the contents of the Artifact Registry after the upload step. [important]
      relevant line: - name: Upload to Google Artifact Registry

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@julesbertrand julesbertrand merged commit 395b256 into develop Nov 6, 2023
7 checks passed
@julesbertrand julesbertrand deleted the fix/cd-push-to-artifact-registry branch November 6, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant