This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
don't parse resource version #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
force-pushed
the
skuznets/stop-parsing-resource-version
branch
from
ad2f60c to
4157e68
Compare
stevekuznetsov
changed the title
Parsing the resourceVersion as an integer is strictly prohibited by the Kubernetes API [1]. During a review of code that would be affected by non-numerical resourceVersions, I came upon this code. As the parsed data is not used for anything, it looks like it's possible to simply remove this parsing logic. [1] https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-versions Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/stop-parsing-resource-version
branch
from
4157e68 to
d4034b9
Compare
|
Thanks for taking a look, @tlbueno ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the resourceVersion as an integer is strictly prohibited by the Kubernetes API [1]. During a review of code that would be affected by non-numerical resourceVersions, I came upon this code. As the parsed data is not used for anything, it looks like it's possible to simply remove this parsing logic.
[1] https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-versions
Signed-off-by: Steve Kuznetsov [email protected]