Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new migration. #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix new migration. #28

wants to merge 5 commits into from

Conversation

atbradley
Copy link

@atbradley atbradley commented Jan 11, 2018

The migration 0002_auto_20170915_0912.py fails with projects that don't use the default openinghours.Company model for premises. This revision corrects that issue.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage remained the same at 85.484% when pulling 308ffff on atbradley:master into 0a80b43 on arteria:master.

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage remained the same at 85.484% when pulling 1951ff5 on atbradley:master into 0a80b43 on arteria:master.

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage increased (+0.05%) to 85.531% when pulling fb98342 on atbradley:master into 0a80b43 on arteria:master.

@atbradley atbradley changed the title Fix install failure Fix new migration. Jan 20, 2018
@imposeren
Copy link
Contributor

Actually I think that "swappable" model is a better approach: conditionally running migrations will cause errors in TestRunner when it will try to serialize data of openinghours.Company model (because app.get_models still has Company model that has no migrations executed for it). See my pull #30

@imposeren
Copy link
Contributor

@atbradley can you check if django-openinghours==0.1.5 solves your issue?

@fmalina fmalina mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants