fix(apdex): show all metrics in report #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassy
reviewed
Oct 12, 2023
| @@ -36,13 +36,21 @@ class ApdexPlugin { | |||
|
|
|||
| function apdexAfterResponse(req, res, userContext, events, done) { | |||
| const total = res.timings.phases.total; | |||
| const counts = { | |||
There was a problem hiding this comment.
Personal preference, but I'd emit all 3 metrics with value of 0 here at the beginning of the function, and keep the rest of the function the same.
hassy
approved these changes
Oct 12, 2023
InesNi
deleted the
ifazlic-art-1400-report-apdex-metrics-even-if-their-count-is-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2209
What
Making
apdexplugin show all 3 metrics in the report even if their count is 0 (even if no metrics were frustrated/satisfied/tolerated) just like we do forvusers.failed. This is needed so that when thethresholdfor the givenapdexmetric is set in theensureplugin, theensuredoes not fail the check for metrics whose count is 0.