Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(playwright): update playwright version to 1.39.0 #2230

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Oct 18, 2023

Description

Updating Playwright version. This will release a canary which can then be used to test and release Fargate.

Release details:

Breaking Changes

Since our previous version (1.37.1), the following breaking changes were released:

  • Playwright no longer downloads browsers automatically: this affects Artillery's engine. However, we can now use the workaround described here of installing the browser directly in the dependency via @playwright/browser-chromium. Despite this being listed as the not recommended option, I believe this is the most sensible option for Artillery as a consumer of Playwright. It also has the nice added bonus of not needing to uninstall the browsers manually anymore.
  • The remaining changes were mostly bug fixes or changes to @playwright/test API's and shouldn't affect us;

Testing

  • Tested against all Playwright examples
  • Tested using the new test.step API

Pre-merge checklist

  • Does this require a changelog entry?

@bernardobridge bernardobridge requested review from hassy and a team October 18, 2023 16:32
@bernardobridge bernardobridge merged commit ed94c28 into main Oct 19, 2023
6 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1409-update-playwright-version-in-engine-to-latest branch October 19, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant