Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish): pin dependant versions of packages to current ones #2263

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Oct 30, 2023

Description

This changes the approach for versioning in packages that depend on other internal packages (artillery, skytrace and @artilleryio/int-core).

Instead of using latest, they will now pin to the versions they're compatible with (the one in the repo at time of publish). This does require us to make sure that when releasing these packages, we follow a certain order (i.e. if you're publishing int-core, you should publish and update int-commons first), but we already do that anyway.

This prevents issues where older versions of (e.g.) artillery are receiving updates that they may not be compatible with.

Pre-merge checklist

  • Does this require an update to the docs? No
  • Does this require a changelog entry? Maybe? It might be good to warn about the change in approach. LMK!

@bernardobridge bernardobridge requested a review from a team October 30, 2023 16:02
@bernardobridge bernardobridge merged commit dc13e3c into main Nov 1, 2023
6 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1424-pin-versions-of-artillery-cli-dependants-eg-publish-metrics branch November 1, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant