Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add typescript support by bundling processor with esbuild #2360

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Dec 8, 2023

Description

Adds support for typescript processors in run and run-fargate.

Some of the decisions that were explored and ended up being made:

  • Disable for now in aws:lambda due to an issue with bundle sizes. Will be explored again later. As this is primarily for Playwright Typescript support, and Playwright does not run in Lambda, this is not urgent;
  • Using esbuild-wasm as it is cross-platform compatible. Regular esbuild also works and installs the platform specific binary, but this is more future-proof for when we do provide Lambda support. This can easily be changed;
  • For now using global.artillery.hasTypescriptProcessor. This can be changed a little bit later by refactoring some of the logic in run, but right now it felt unnecessary to tackle immediately.

Pre-merge checklist

  • Does this require an update to the docs? Yes!
  • Does this require a changelog entry? Yes!

@bernardobridge bernardobridge requested review from hassy and a team December 8, 2023 11:40
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
esbuild-wasm 0.19.8 network, filesystem +0 11.8 MB evanw

@bernardobridge
Copy link
Contributor Author

bernardobridge commented Dec 14, 2023

Some action items to do here:

  • Not allow running in AWS Lambda for now (due to package size issues)
  • Make sure it works with configs in different folders
  • Error handling
  • Revisit some of the esbuild configs
  • Create some tests

@bernardobridge bernardobridge marked this pull request as ready for review December 14, 2023 12:30
@bernardobridge bernardobridge merged commit 6103717 into main Dec 15, 2023
7 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1513-mvp-of-typescript-cli-support-using-esbuild branch December 15, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant