Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fargate): run datadog agent only when datadog api key is configured #2393

Merged
merged 4 commits into from
Jan 3, 2024
Merged

fix(fargate): run datadog agent only when datadog api key is configured #2393

merged 4 commits into from
Jan 3, 2024

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented Jan 3, 2024 •
edited
Loading

Description

Fix for 2 Issues in the Fargate Datadog agent container setup:

  1. Fixing a typo in the 'DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_GRPC_ENDPOINT' variable for the Datadog Agent

  2. Adding a placeholder key for the DD_API_KEY variable to stop Fargate tests that don't need datadog-agent to break:

    • Currently the Datadog agent container is built and runs on every Fargate test, even when users are not trying to send data to Datadog. This is causing tests that don't need datadog-agent to break, since the Datadog agent container exits without the Datadog API key set.

@InesNi InesNi requested a review from a team January 3, 2024 16:03
@hassy hassy merged commit fb0b4c6 into main Jan 3, 2024
10 checks passed
@hassy hassy deleted the ifazlic-art-1543-run-datadog-agent-only-when-datadog-api-key-is-present branch January 3, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InesNi @hassy