fix(cli): allow beforeafter validation schema to run engines without flow #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobridge
changed the title
bernardobridge
changed the title
bernardobridge
changed the title
bernardobridge
commented
Jan 5, 2024
| @@ -105,9 +105,13 @@ const scenarioItem = Joi.object({ | |||
| }); | |||
|
|
|||
| const beforeAfterSchema = Joi.object({ | |||
There was a problem hiding this comment.
Previously the schema would look at config.engines to determine this. However, this is more complicated than just looking at the engine field within before/after itself:
- If it doesn't have it, it's http (default), so it needs flow.
- If it has it, and if it's
socketio,wsorhttp, it needs flow. Otherwise it does not require flow (e.g. custom engine orplaywright).
Looking at config.engines doesn't actually make sense, since you could be putting a config there for an engine you're using in your scenario, but not in before/after.
2 tasks
bernardobridge
commented
Jan 5, 2024
Comment on lines
+496
to
+501
|
|
||
| if (typeof engine === 'undefined') { | ||
| throw new Error( | ||
| `Failed to run ${hook} hook: unknown engine "${name}". Did you forget to include it in "config.engines.${name}"?` | ||
| ); | ||
| } |
There was a problem hiding this comment.
similar logic to #2101 for consistency
…lidate-script-schema-to-run-arbitrary
bernardobridge
deleted the
bernardobridge/art-1547-allow-beforeafter-validate-script-schema-to-run-arbitrary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In theory any
enginecan run as abefore/afterhook. However, if the engine doesn't includeflow, it will currently fail. This PR fixes that, and also introduces an error message whenbefore.engineis configured without the correspondingconfig.engine(similar to #2101).Having this will enable e.g.
playwrightscenarios to be run as abefore.Note: I will fix the VS code schema separately in another PR.
Pre-merge checklist