fix(publish-metrics): otel tracing bug #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for OTel traces arriving inconsistently (in number and format) to observability platforms when running in Fargate
Context
Two different issues were observed, and usually at least one would happen:
Note: the issues would not happen on local runs, and issue 2. seems to only happen on Datadog.
The issues seem to be a result of multiple factors:
traceProvider
shut down prematurely.maxExportBatchSize
and eventually themaxQueueSize
could be reached in which case spans would be droppedSolution
This PR addresses the mentioned factors that seem to be causing the issues:
maxExportBatchSize
,maxQueueSize
and thescheduledDelayMillis
were increased, and the settings exposed to user for configuration if needed (this would allow users to adjust the number of traces that a batch can take before dropping them)traceProvider
in order to wait for the exporters flush.