Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close Info bottom sheet on tapping Close button #11455

Merged

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Jan 29, 2025

Description

Close Info bottom sheet on tapping Close button.

Before After
https://github.com/user-attachments/assets/98cef454-4e4a-4220-96e7-46fabed6f19e https://github.com/user-attachments/assets/87477406-f228-46cd-a870-c723bdadb32f

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix: Correctly close Info bottom sheet on tapping Close button - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@olerichter00 olerichter00 self-assigned this Jan 29, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 29, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (fix: Correctly close Info bottom sheet on tapping Close button - ole - olerichter00)

Generated by 🚫 dangerJS against c3a23a4

brainbicycle
brainbicycle previously approved these changes Jan 29, 2025
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable! Thank you!

@olerichter00 olerichter00 added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jan 29, 2025
@olerichter00 olerichter00 force-pushed the olerichter00/close-info-bottom-sheet-on-tapping-close-button branch from 93f40dd to 5f5a76b Compare February 3, 2025 17:50
@olerichter00 olerichter00 force-pushed the olerichter00/close-info-bottom-sheet-on-tapping-close-button branch from 5d614b7 to 48eeb41 Compare February 7, 2025 09:44
@artsy-peril artsy-peril bot merged commit fa6269c into main Feb 7, 2025
7 checks passed
@artsy-peril artsy-peril bot deleted the olerichter00/close-info-bottom-sheet-on-tapping-close-button branch February 7, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants