feat: Home view prefetching part III #11497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
force-pushed
the
olerichter00/home-view-prefetching-part-iii
branch
from
c6bfec2 to
ce79c79
Compare
olerichter00
force-pushed
the
olerichter00/home-view-prefetching-part-iii
branch
from
ce79c79 to
d155490
Compare
olerichter00
force-pushed
the
olerichter00/home-view-prefetching-part-iii
branch
from
d155490 to
5b2c7cd
Compare
olerichter00
commented
Feb 6, 2025
| } | ||
|
|
||
| return ( | ||
| <Box justifyContent="center"> | ||
| <TouchableOpacity | ||
| <RouterLink |
There was a problem hiding this comment.
Replacing TouchableOpacity with RouterLink causes issues with highlighting the indicator on touch. I fixed the issue in #11499
olerichter00
requested review from
MounirDhahri
and removed request for
MounirDhahri
damassi
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ONYX-1496
Description
Home view prefetching part III:
Implements prefetching for the home view's Article rail and the Activity indicator.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.