fix: Correctly filter CollectorProfileUpdatePromptNotificationItem in Activity rail

[olerichter00]

This PR resolves PBRW-392

Description

I’ve looked into the code, and it could be related to this line, which prevents rendering activity items with the type name CollectorProfileUpdatePromptNotificationItem man shrugging Activities by this type get filtered out in the rail item component instead of the rail. This could be the reason why the rail is still rendering.

PR Checklist

• I have tested my changes on iOS and Android.
• I hid my changes behind a feature flag, or they don't need one.
• I have included screenshots or videos, or I have not changed the UI.
• I have added tests, or my changes don't require any.
• I added an app state migration, or my changes do not require one.
• I have documented any follow-up work that this PR will require, or it does not require any.
• I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

• I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Changelog updates

Cross-platform user-facing changes

• Correctly filter CollectorProfileUpdatePromptNotificationItem in Activity rail. - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

[ArtsyOpenSource]

This PR contains the following changes:

• Cross-platform user-facing changes (Correctly filter CollectorProfileUpdatePromptNotificationItem in Activity rail. - ole - olerichter00)

Generated by 🚫 dangerJS against a55e0c0

[MounirDhahri]

good catch! I wonder if there is another way so this logic doesn't break the next time we introduce a new type. That can be something we look for later

[olerichter00]

Yes! I guess we should not filter out by type just in the item component and should use the existing helper function.

Typing is quite wild in the Activity panel and may have caused the problem.