Riscv ecp5 #12
Open
Riscv ecp5 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeckmann
reviewed
May 8, 2020
|
|
||
| # Debugging/Optimization | ||
| ifeq ($(DEBUG), 1) | ||
| LDFLAGS += specs=rdimon.specs |
There was a problem hiding this comment.
This causes arm-none-eabi-gcc: error: specs=rdimon.specs: No such file or directory for me. Sorry but what does this do? never seen this before :). I'm on gcc 9.3.0.
|
There is a - sign missing, it should say '-specs=rdimon.specs'. It brings
in semihosting based debugging.
I'm not sure how you were doing your printf output before but chances are
that you might need to re-add some libraries to get that back (there's no
printf in the non debug version purposefully because it's generally a
pretty big routine).
Regards
Dave
…On Fri, 8 May 2020, 21:42 Konrad Beckmann, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Makefile
<#12 (comment)>:
> + -Wno-unused-parameter \
+ -Wunreachable-code \
+ -ffreestanding
+
+# Compiler flags for defining UF2 configuration
+CFLAGS += \
+ -DAPP_START_ADDRESS=$(APP_START_ADDRESS) \
+ -DBOARD_FLASH_BASE=$(BOARD_FLASH_BASE) \
+ -DUF2_FAMILY=$(UF2_FAMILY) \
+ -DCFG_TUSB_MCU=$(TUSB_MCU)
+
+LDFLAGS += $(CFLAGS) -fshort-enums -Wl,$(LD_FILE) ***@***.*** -Wl,-cref -Wl,-gc-sections
+
+# Debugging/Optimization
+ifeq ($(DEBUG), 1)
+LDFLAGS += specs=rdimon.specs
This causes arm-none-eabi-gcc: error: specs=rdimon.specs: No such file or
directory for me. Sorry but what does this do? never seen this before :).
I'm on gcc 9.3.0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJTBD4VLCKVCJ6EIHBNY7TRQRVBXANCNFSM4M2R6VDQ>
.
|
|
Aha alright. If i add a |
|
In order to better review this PR, it would be nice to split it up into Makefile rewrite, and ecp5/colorlight separately. There are a lot of changes :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECP5 integration and build system changes.