Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed naming #638

Merged
merged 3 commits into from
Aug 23, 2022
Merged

fixed naming #638

merged 3 commits into from
Aug 23, 2022

Conversation

arunavabasucom
Copy link
Owner

Fixes #636

@arunavabasucom arunavabasucom requested a review from suzil as a code owner August 22, 2022 14:32
@suzil
Copy link
Collaborator

suzil commented Aug 22, 2022

Fine for me, but I'll let @erwanp review the file name formatting for this PR.

@suzil suzil requested a review from erwanp August 22, 2022 15:57
@arunavabasucom
Copy link
Owner Author

It is perfectly working @erwanp

Screenshot 2022-08-23 at 6 46 46 PM

erwanp
erwanp approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@erwanp erwanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@suzil suzil merged commit d01263f into arunavabasucom:main Aug 23, 2022
@arunavabasucom arunavabasucom deleted the naming#636 branch August 24, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanp erwanp erwanp approved these changes

@suzil suzil suzil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download-spectrum name
3 participants
@arunavabasucom @suzil @erwanp